Repository navigation
fix: 30252 Animation is not visible on desktop but visible on Mobile in sign in Modal - #30954
Conversation
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@thesahindia We already handle it in https://github.com/Expensify/App/blob/main/src/pages/signin/SignInHeroImage.js. Here's result in safari:
Please correct me if I'm wrong sth. Thanks |
|
@tienifr, SignInModal is at RHN so the Right now the image size is for the desktop but we want the mobile size What we want -
|
|
@thesahindia Thanks for your suggestion, I updated the PR and evidences |
|
@tienifr, app is crashing at the login page on native
Also add videos for all platforms! |
|
@thesahindia I updated the videos for all platforms, but I don't know why I can't open public room on mweb/chrome. I even tested it on main and it didn't work. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-11-17.at.1.44.36.PM.movAndroid: mWeb ChromeiOS: NativeScreen.Recording.2023-11-17.at.2.41.21.PM.moviOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2023-11-17.at.1.57.28.PM.movMacOS: DesktopScreen.Recording.2023-11-17.at.3.07.44.PM.mov |
Yeah, I am experiencing the same. Can you post this at the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.2-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀
|





Details
Amount not show when split bill in offline mode. This PR fixes that.
Fixed Issues
$ #30252
PROPOSAL: #30252 (comment)
Tests
Offline tests
Same as Tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2023-11-17.at.12.25.27.1.mp4
Android: mWeb Chrome
Screen.Recording.2023-11-17.at.14.44.11.mp4
iOS: Native
Screen.Recording.2023-11-16.at.16.16.07.mov
iOS: mWeb Safari
Screen.Recording.2023-11-07.at.10.47.26.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-13.at.10.57.25.mov
MacOS: Desktop
Screen.Recording.2023-11-07.at.10.59.04.mov